Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: cleanup duplicate lint job (#2402) #2409

Merged
merged 5 commits into from
Aug 1, 2021
Merged

github: cleanup duplicate lint job (#2402) #2409

merged 5 commits into from
Aug 1, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2402

What problem does this PR solve?

cleanup duplicate lint job

What is changed and how it works?

cleanup duplicate lint job. They are already executed in check.

Check List

Tests

  • No code

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2021
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. do-not-merge/cherry-pick-not-approved labels Jul 29, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 30, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2021
@amyangfei amyangfei added this to the v4.0.15 milestone Jul 30, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5f3c1be

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2409 (ba726fc) into release-4.0 (753073a) will increase coverage by 1.5188%.
The diff coverage is 58.6206%.

@@                 Coverage Diff                 @@
##           release-4.0      #2409        +/-   ##
===================================================
+ Coverage      53.7661%   55.2849%   +1.5188%     
===================================================
  Files              153        165        +12     
  Lines            15958      19546      +3588     
===================================================
+ Hits              8580      10806      +2226     
- Misses            6475       7720      +1245     
- Partials           903       1020       +117

@amyangfei amyangfei mentioned this pull request Jul 31, 2021
Merged
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit f54250a into pingcap:release-4.0 Aug 1, 2021
ti-chi-bot referenced this pull request in ti-community-infra/configs Aug 2, 2021
@amyangfei
config(ticdc): remove some required_status_checks in release-4.0 (#387)
cc20efe 
Ref: https://github.com/pingcap/ticdc/pull/2409, `Lint` check has been removed.

Other checks are kept the same required_status_checks with release-5.0/release-5.1 and master branch in release-4.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei Awaiting requested review from amyangfei

@lonng lonng Awaiting requested review from lonng

Assignees

@Rustin170506 Rustin170506

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
v4.0.15
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @amyangfei @codecov-commenter @lonng @Rustin170506